Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastwalk to v1.0.9 to fix handling of disk root paths on Windows #4063

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

charlievieth
Copy link
Contributor

Update fastwalk to v1.0.9.

This fixes an issue on Windows when the argument to --walker-root was the root of a disk drive (e.g. C:\). Instead of walking the disk root C:\ it walked the current directory. This occurred because we were transforming the fully qualified path C:\ to the relative path C: which caused the current directory to be walked (docs).

Fixes: #4027

@charlievieth charlievieth mentioned this pull request Oct 25, 2024
10 tasks
@charlievieth
Copy link
Contributor Author

Example output:
Screenshot 2024-10-25 at 10 49 45 AM

@junegunn junegunn merged commit 71fad63 into junegunn:master Oct 25, 2024
5 checks passed
@junegunn
Copy link
Owner

Thank you very much for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--walker-root not used
2 participants